DEV UI - Enable error handling for JSON RPC client and normal requests-response cases

[michalvavrik]

JSON RPC client doesn't take into consideration that failed requests doesn't have response-type (more precisely, it's data property contains error object and not response object), which means requests throws error on devUiResponse being undefined (JS analogy to NPE) here

quarkus/extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/controller/jsonrpc.js

Line 248 in 2a867ee

var messageType = devUiResponse.messageType;

This happens (at the very least) when my JSON RPC Service returns failed Uni

public class MyJsonRpcService {

 public Uni<String> fail() {
   return Uni.createFrom().failure(new RuntimeException());
 }

}

and on client side, Promise then method or catch are never called. In practice, it means if I want to provide error handling, I have to introduce wrapper that contains actual response and error object and make sure Uni is never failed.

I'd rather do this

this.jsonRpc
            .fail()
            .then(response => {
                notifier....
            })
            .catch(error => {
               notifier....
            });

@phillip-kruger I need to provide error handling for #32031 as we have external requests to OIDC providers, but please let me know if you want me to open issue and handle it yourself. I only added here handling of normal request-responses that fails as that's what I need. Thanks!

[phillip-kruger]

Nice ! Thanks

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.