Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed manual OTel properties for fallback, since they are now provided automatically #33565

Merged
merged 1 commit into from
May 24, 2023

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented May 23, 2023

The issue was caused by the manual list provided of the OTel properties. Because this was provided manually and the interceptor was applied to every config phase, there was no distinction between build time or runtime properties. This resulted in the property appearing to be available when it was not.

@quarkus-bot
Copy link

quarkus-bot bot commented May 23, 2023

/cc @brunobat (opentelemetry)

@quarkus-bot
Copy link

quarkus-bot bot commented May 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @radcortez !

@radcortez radcortez merged commit 8101c3e into quarkusio:main May 24, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 24, 2023
@radcortez radcortez deleted the fix-33493 branch July 5, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ConfigValue instance for quarkus.otel.sdk.disabled is null during relocation
2 participants