Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document io_uring #33544

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Document io_uring #33544

merged 1 commit into from
Jun 6, 2023

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented May 23, 2023

@cescoffier cescoffier force-pushed the document-io_uring branch 2 times, most recently from 937724d to 1e9bedb Compare May 23, 2023 08:15
@franz1981
Copy link
Contributor

This is great @cescoffier , probably we could add a troubleshooting section that point to https://github.com/netty/netty-incubator-transport-io_uring#faq and netty/netty-incubator-transport-io_uring#152 (typical issue: why it's slower then epoll? try reducing the number of I/O thread(s))

@cescoffier cescoffier force-pushed the document-io_uring branch from 1e9bedb to 45252cc Compare May 23, 2023 08:37
@github-actions
Copy link

github-actions bot commented May 23, 2023

🙈 The PR is closed and the preview is expired.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a few minor things.

docs/src/main/asciidoc/vertx-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/vertx-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/vertx-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/vertx-reference.adoc Outdated Show resolved Hide resolved
@cescoffier cescoffier force-pushed the document-io_uring branch from 45252cc to f8e326b Compare May 23, 2023 13:13
@cescoffier cescoffier force-pushed the document-io_uring branch from f8e326b to f8692ef Compare May 23, 2023 16:50
Copy link
Contributor

@franz1981 franz1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cescoffier !

@gsmet gsmet merged commit 51579fa into quarkusio:main Jun 6, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone Jun 6, 2023
@cescoffier cescoffier deleted the document-io_uring branch June 7, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Integrate io_uring support
4 participants