Do not create session and PKCE encryption keys if only bearer tokens are expected #33476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pedroigor
approved these changes
May 19, 2023
sberyozkin
force-pushed
the
fix_secret_key_warning
branch
from
bfdf445 to
a5ae97e
Compare
sberyozkin
force-pushed
the
fix_secret_key_warning
branch
from
a5ae97e to
77d1bb9
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
Thanks @pedroigor,. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33475.
Session cookie and PKCE verifier encryption keys are only relevant when Users are authenticating into
quarkus.oidc.application-type=web-apporquarkus.oidc.application-type=hybrid, when Quarkus itself manages authorization code flow.This PR avoids creating such keys when only bearer tokens are expected - PKCE and session encryption will never be used in such cases.