Read process output from a new Thread #33438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
approved these changes
May 17, 2023
geoand
added
the
triage/waiting-for-ci
iocanel
force-pushed
the
container-invoker-fixes
branch
from
de0b241 to
5c237be
Compare
|
Can you describe the rationale behind the latest changes? |
|
@geoand description updated. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request uses a new Thread to read the process output (in ExecUtil).
This seems to work around the issue we are dealing with in pull request: #33410
Update
The failure seems to originate from an SO that occurs when logging. The SO is most probably a side effect of https://github.com/apache/maven-script-interpreter/blob/master/src/main/java/org/apache/maven/shared/scriptinterpreter/GroovyScriptInterpreter.java#L54 messing with System.out / System.err. This seem to somehow upset jboss logging, causing SO.
The original pull request moved logging to each thread, so the SO didn't affect the main thread. However, it didn't fix the logging output which created log files of almost 2G.
The followup commit introduces the option to use system logging, which seems to be a better choice for code invoked from maven-invoker plugin and GroovySciprtInterpreter.
It also updates the verify.groovy files that use Exec so that they all use system logging.