Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutabillity in Stork gRPC channel when fetching Stork services #33352

Merged
merged 1 commit into from
May 15, 2023

Conversation

alesj
Copy link
Contributor

@alesj alesj commented May 14, 2023

No description provided.

@alesj alesj requested a review from cescoffier May 14, 2023 12:52
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label May 14, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented May 14, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@alesj alesj requested a review from geoand May 14, 2023 16:06
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix a known issue?

@cescoffier
Copy link
Member

@alesj can you update the title to be a bit more descriptive?

@alesj alesj changed the title Fix mutabillity Fix mutabillity in Stork gRPC channel when fetching Stork services May 14, 2023
@alesj
Copy link
Contributor Author

alesj commented May 14, 2023

@cescoffier title fixed

@alesj
Copy link
Contributor Author

alesj commented May 14, 2023

Does this fix a known issue?

@geoand I stumbled upon it when testing some other stuff ...

@geoand
Copy link
Contributor

geoand commented May 15, 2023

👍

@geoand geoand merged commit e03a978 into quarkusio:main May 15, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants