Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument parsing for CLI plugins #33304

Merged
merged 2 commits into from
May 11, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented May 11, 2023

Resolves: #33303

Updates:

  • added test to prevent more regressions in the future

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels May 11, 2023
@iocanel iocanel requested a review from maxandersen May 11, 2023 11:49
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented May 11, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel iocanel merged commit 43a5358 into quarkusio:main May 11, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in CLI plugin argument parsing
2 participants