Make it easier to get well known properties from TokenIntrospection #33283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
May 10, 2023
This comment has been minimized.
This comment has been minimized.
|
Thanks George @gastaldi , I'll rerun a bit later, as too many jobs have failed for some reasons |
geoand
reviewed
May 11, 2023
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/TokenIntrospection.java
Outdated
Show resolved
Hide resolved
sberyozkin
force-pushed
the
oidc_token_introspection_improvement
branch
from
98de656 to
9a0744e
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33282.
This PR adds
TokenIntrospectionTest, adds a few methods toTokenIntrospectionto make it easier to get well known properties, which are covered here:https://datatracker.ietf.org/doc/html/rfc7662
I added methods for nearly all of them which can be useful in the user code, for now I've stopped short of adding expiry/issued at as Quarkus manages them itself, they can be still retrieved as JSON properties if needed.
Some OIDC code got simplified a bit as well.