Add prerequisites to contribution guide plus some copy edits. #33234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
rolfedh
force-pushed
the
add-prereqs-to-contrib-guide
branch
from
7306c85 to
dbafabc
Compare
|
🙈 The PR is closed and the preview is expired. |
rolfedh
force-pushed
the
add-prereqs-to-contrib-guide
branch
from
dbafabc to
b3d5ee8
Compare
sheilamjones
approved these changes
May 10, 2023
There was a problem hiding this comment.
@rolfedh: I just had a couple of minor comments, but all your changes look good to me.
rolfedh
force-pushed
the
add-prereqs-to-contrib-guide
branch
from
b3d5ee8 to
8111d56
Compare
rolfedh
force-pushed
the
add-prereqs-to-contrib-guide
branch
4 times, most recently
from
12545b7 to
bc432e4
Compare
ebullient
reviewed
May 11, 2023
rolfedh
force-pushed
the
add-prereqs-to-contrib-guide
branch
from
bc432e4 to
7a88fba
Compare
|
Thank you, @sheilamjones, @michelle-purcell, and @ebullient for your thoughtful reviews. |
|
@gsmet I believe this is ready for merge. |
rolfedh
force-pushed
the
add-prereqs-to-contrib-guide
branch
from
7a88fba to
7c0de24
Compare
ebullient
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33227
Adds instructions for using
include::{includes}/prerequisites.adoc[].Includes some minor copyedits.