Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DebugCodeInfoUseSourceMappings with GraalVM >= 23.0 #33203

Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented May 8, 2023

Starting with GraalVM 23.1 debug info generation defaults to not using SourceMappings when building the CompilationResultTree. This choice was made in order to improve build times (only when generating debug info), but as expected it comes at the cost of less accurate generated-code to source mapping.

Relates to Karm/mandrel-integration-tests#154

cc @jerboaa

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Starting with GraalVM 23.0 debug info generation defaults to not using
`SourceMapping`s when building the `CompilationResultTree`. This choice
was made in order to improve build times (only when generating debug
info), but as expected it comes at the cost of less accurate
generated-code to source mapping.
@zakkak zakkak force-pushed the 2023-05-08-keepsourcemappings-when-debugging branch from 2597b34 to 2f34a09 Compare May 22, 2023 08:33
@zakkak zakkak changed the title Enable DebugCodeInfoUseSourceMappings with GraalVM >= 23.1 Enable DebugCodeInfoUseSourceMappings with GraalVM >= 23.0 May 22, 2023
@zakkak zakkak marked this pull request as ready for review May 22, 2023 08:34
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good.

@zakkak zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 22, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented May 22, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@zakkak zakkak merged commit 4eb4c63 into quarkusio:main May 22, 2023
@zakkak zakkak deleted the 2023-05-08-keepsourcemappings-when-debugging branch May 22, 2023 13:57
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 22, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants