-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus Gradle Plugin: tests with encrypted configuration #33173
Conversation
Setting this to draft, because I want to add a test that has a "real" encrypted value and validate it. |
I probably need to add a way to completely disable secret handler expressions at the builder level, because this will happen with other handler names found in the configuration, so setting a fake for |
I suspected that this will be the case.
Hm - yea - that deserves a change in |
b599a7a
to
90dd954
Compare
Updated the PR to only add tests verifying the behavior. |
This comment has been minimized.
This comment has been minimized.
90dd954
to
c657f61
Compare
Let's rebase and get another CI run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get this in provided CI is happy about it.
This comment has been minimized.
This comment has been minimized.
c657f61
to
1db964e
Compare
This comment has been minimized.
This comment has been minimized.
@snazy can you rebase with the latest main before we merge this? |
1db964e
to
6a32789
Compare
This comment has been minimized.
This comment has been minimized.
Looks like CI doesn't like it, can you verify @snazy ? |
Oh yea - the crypto-tests now fail with |
6a32789
to
cdbb910
Compare
This comment has been minimized.
This comment has been minimized.
As decribed in quarkusio#33135, using encrypted configuration values did not work with the Gradle plugin since Quarkus 3.0.0, prior to SmallRye Config 3.3.0 (quarkusio#33079). This change just adds tests to validate the behavior.
cdbb910
to
564299d
Compare
Status for workflow
|
Thanks! |
As decribed in #33135, using encrypted configuration values did not work with the Gradle plugin since Quarkus 3.0.0, prior to SmallRye Config 3.3.0 (#33079).
This change just adds tests to validate the behavior.