Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus Gradle Plugin: tests with encrypted configuration #33173

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

snazy
Copy link
Contributor

@snazy snazy commented May 6, 2023

As decribed in #33135, using encrypted configuration values did not work with the Gradle plugin since Quarkus 3.0.0, prior to SmallRye Config 3.3.0 (#33079).

This change just adds tests to validate the behavior.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels May 6, 2023
@snazy snazy marked this pull request as draft May 6, 2023 11:00
@snazy
Copy link
Contributor Author

snazy commented May 6, 2023

Setting this to draft, because I want to add a test that has a "real" encrypted value and validate it.

@radcortez
Copy link
Member

I probably need to add a way to completely disable secret handler expressions at the builder level, because this will happen with other handler names found in the configuration, so setting a fake for aes-gcm-nopadding is not going to be enough.

@snazy
Copy link
Contributor Author

snazy commented May 6, 2023

setting a fake for aes-gcm-nopadding is not going to be enough.

I suspected that this will be the case.

completely disable secret handler expressions at the builder level,

Hm - yea - that deserves a change in SmallRyeConfigBuilder.

@radcortez
Copy link
Member

@snazy snazy changed the title Quarkus Gradle Plugin: allow encrypted configuration Quarkus Gradle Plugin: tests with encrypted configuration Jul 27, 2023
@snazy snazy force-pushed the gradle-crypto-config branch from b599a7a to 90dd954 Compare July 27, 2023 10:18
@snazy
Copy link
Contributor Author

snazy commented Jul 27, 2023

Updated the PR to only add tests verifying the behavior.

@snazy snazy marked this pull request as ready for review July 27, 2023 10:19
@quarkus-bot

This comment has been minimized.

@gsmet gsmet force-pushed the gradle-crypto-config branch from 90dd954 to c657f61 Compare October 5, 2023 16:09
@gsmet
Copy link
Member

gsmet commented Oct 5, 2023

Let's rebase and get another CI run.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get this in provided CI is happy about it.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 5, 2023
@quarkus-bot

This comment has been minimized.

@snazy snazy force-pushed the gradle-crypto-config branch from c657f61 to 1db964e Compare October 9, 2023 08:37
@quarkus-bot

This comment has been minimized.

@gastaldi gastaldi added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 8, 2024
@gastaldi
Copy link
Contributor

gastaldi commented Feb 8, 2024

@snazy can you rebase with the latest main before we merge this?

@snazy snazy force-pushed the gradle-crypto-config branch from 1db964e to 6a32789 Compare February 8, 2024 17:05
@snazy
Copy link
Contributor Author

snazy commented Feb 8, 2024

@snazy can you rebase with the latest main before we merge this?

@gastaldi done

This comment has been minimized.

@gastaldi
Copy link
Contributor

gastaldi commented Feb 8, 2024

Looks like CI doesn't like it, can you verify @snazy ?

@gastaldi gastaldi removed triage/needs-rebase This PR needs to be rebased first because it has merge conflicts triage/waiting-for-ci Ready to merge when CI successfully finishes labels Feb 8, 2024
@snazy
Copy link
Contributor Author

snazy commented Feb 8, 2024

Oh yea - the crypto-tests now fail with Caused by: java.util.NoSuchElementException: SRCFG00046: Could not find a secret key handler for aes-gcm-nopadding - seems that #38007 is actually a regression, based on the original commit message for this PR :(

This comment has been minimized.

As decribed in quarkusio#33135, using encrypted configuration values did not
work with the Gradle plugin since Quarkus 3.0.0, prior to SmallRye
Config 3.3.0 (quarkusio#33079).

This change just adds tests to validate the behavior.
@snazy snazy force-pushed the gradle-crypto-config branch from cdbb910 to 564299d Compare February 8, 2024 18:18
Copy link

quarkus-bot bot commented Feb 8, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 564299d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit ad904bc into quarkusio:main Feb 8, 2024
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 8, 2024
@gastaldi
Copy link
Contributor

gastaldi commented Feb 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants