-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Ensure that ConfigBuilder classes work in native mode to 2.13 #32278
Conversation
radcortez
commented
Mar 30, 2023
- Fixes Quarkus 2.13 test extension tests fail with the 22.3 mandrel builder image #32152
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to fix 2.13 CI. I will have a look at this this week-end.
The failures in WARN [org.jbo.res.cli.jax.i18n] (Finalizer) RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ApacheHttpClient43Engine instance for you. Please close clients yourself. I guess we also need #31496. |
@radcortez yeah I have to backport a few CI fixes to older branches. |
This fix is needed because without it main fails, for example in io.quarkus.it.resteasy.reactive.elytron.FruitResourceIT with a CNFE when trying to load io.quarkus.security.runtime.QuarkusSecurityRolesAllowedConfigBuilder
Failing Jobs - Building 28ea588
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment
! Skipped: extensions/avro/deployment extensions/csrf-reactive/deployment extensions/grpc/deployment and 115 more 📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment✖
⚙️ JVM Tests - JDK 18 #- Failing: integration-tests/logging-gelf
📦 integration-tests/logging-gelf✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green enough.
This fixes the CI failure related to the test extension tests when using the 22.3 builder image. See: quarkusio/quarkus#32278
This fixes the CI failure related to the test extension tests when using the 22.3 builder image. See: quarkusio/quarkus#32278