-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize RESTEasy Reactive exception logging #31975
Conversation
The PR does a few things: * Adds debug logging for WebApplicationException instances * Eliminates duplicate logging of exceptions * Adds a hack to ensure that application provided IOException cases are logged properly Closes: quarkusio#31945
Failing Jobs - Building b40b179
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/grpc/deployment
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/opentelemetry/deployment and 33 more 📦 extensions/grpc/deployment✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, you're translating an IOException raised from either an InvocationHandler or an ResourceRequestFilterHandler to wrap the IOException into a UncheckedIOException, so QuarkusErrorHandler can handle it correctly, right?
Not sure if we can throw directly the UncheckedIOException exception (tho this is not very user-friendly), or fix it directly in QuarkusErrorHandler.
Exactly, it's a total hack... |
We can't really, because real |
The PR does a few things:
Closes: #31945