Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize RESTEasy Reactive exception logging #31975

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 20, 2023

The PR does a few things:

  • Adds debug logging for WebApplicationException instances
  • Eliminates duplicate logging of exceptions
  • Adds a hack to ensure that application provided IOException cases are logged properly

Closes: #31945

The PR does a few things:

* Adds debug logging for WebApplicationException instances
* Eliminates duplicate logging of exceptions
* Adds a hack to ensure that application provided IOException
cases are logged properly

Closes: quarkusio#31945
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 20, 2023

Failing Jobs - Building b40b179

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.devmode.AnnotationProcessorSimpleModuleDevModeTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/grpc/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/opentelemetry/deployment and 33 more

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

java.util.concurrent.RejectedExecutionException
	at org.jboss.threads.RejectingExecutor.execute(RejectingExecutor.java:38)
	at org.jboss.threads.EnhancedQueueExecutor.rejectShutdown(EnhancedQueueExecutor.java:2136)

Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you're translating an IOException raised from either an InvocationHandler or an ResourceRequestFilterHandler to wrap the IOException into a UncheckedIOException, so QuarkusErrorHandler can handle it correctly, right?

Not sure if we can throw directly the UncheckedIOException exception (tho this is not very user-friendly), or fix it directly in QuarkusErrorHandler.

@geoand
Copy link
Contributor Author

geoand commented Mar 21, 2023

So, you're translating an IOException raised from either an InvocationHandler or an ResourceRequestFilterHandler to wrap the IOException into a UncheckedIOException, so QuarkusErrorHandler can handle it correctly, right?

Exactly, it's a total hack...

@geoand
Copy link
Contributor Author

geoand commented Mar 21, 2023

or fix it directly in QuarkusErrorHandler.

We can't really, because real IOException happen all the time due to clients closing connections prematurely.

@geoand geoand merged commit 29c1abe into quarkusio:main Mar 21, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 21, 2023
@geoand geoand deleted the #31945 branch March 21, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent error logging of thrown exceptions in quarkus-resteasy-reactive-jackson
2 participants