Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI: SmallRye Fault Tolerance #31902

Merged
merged 4 commits into from
Mar 17, 2023

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Mar 16, 2023

Related to #31315

@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 16, 2023

There are 3 tiny commits with minor improvements, and then 1 bigger commit with the new Dev UI. I'm mainly asking for review of that commit.

@Ladicek Ladicek mentioned this pull request Mar 16, 2023
56 tasks
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 16, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@phillip-kruger
Copy link
Member

@Ladicek I'll review later today.

Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice Dev UI.

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @Ladicek !

@phillip-kruger phillip-kruger merged commit bd51374 into quarkusio:main Mar 17, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 17, 2023
@Ladicek Ladicek deleted the fault-tolerance-devui branch March 20, 2023 07:46
@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 20, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants