-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent ContextNotActiveException during invalid config validation if resteasy-reactive module is present #31518
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
We seem to also have #31544 which attempts to fix the problem |
I think the approach taken in this PR here makes more sense |
This comment has been minimized.
This comment has been minimized.
@luca-bassoricci I force pushed to your branch to fix the formatting issue. |
Grazie :) |
Lines 29 to 35 in a74aa01
I used this kind of solution because I found it was used elsewhere. |
Failing Jobs - Building da65125
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/reactive-routes/deployment
! Skipped: extensions/resteasy-reactive/quarkus-resteasy-reactive-jackson/deployment extensions/resteasy-reactive/quarkus-resteasy-reactive-jaxb/deployment extensions/resteasy-reactive/quarkus-resteasy-reactive-jsonb/deployment and 9 more 📦 extensions/reactive-routes/deployment✖
|
Check for an active RequestContext before accessing ResteasyReactiveLocaleResolver#currentVertxRequest to prevent ContextNotActiveException
I addes only 1 test in
integration-tests\hibernate-validator-resteasy-reactive
module becauseextensions\hibernate-validator\deployment
doesn't useresteasy-reactive
which is a mandatory module to raise the problem.I'm also looking to reproduce the problem in our backend code with some
@RestClient
s interaction but takes time.Fixes #31434