Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the container image card #31435

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Implement the container image card #31435

merged 1 commit into from
Mar 1, 2023

Conversation

cescoffier
Copy link
Member

No description provided.

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file labels Feb 27, 2023
@cescoffier cescoffier mentioned this pull request Feb 27, 2023
Closed
56 tasks
gsmet
gsmet reviewed Feb 27, 2023
View reviewed changes
extensions/container-image/runtime/pom.xml
Comment on lines +28 to +31
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-mutiny</artifactId>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to add a runtime dependency just for the sake of the Dev UI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I need to stream, and there is not much I can do without Mutiny. I don't believe it's a problem, as mutiny will likely be there.

@quarkus-bot

This comment has been minimized.

Sign in to view
@cescoffier cescoffier force-pushed the devui-container-image branch from 8e2410c to 23407ea Compare February 28, 2023 15:23
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2023

Failing Jobs - Building 23407ea

Status Name Step Failures Logs Raw logs
✔️ Devtools Tests - JDK 11
✔️ Devtools Tests - JDK 11 Windows
✖ Devtools Tests - JDK 17 Build Failures Logs Raw logs
✖ Maven Tests - JDK 11 Build Failures Logs Raw logs
⌛ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 17 #

- Failing: integration-tests/devtools

📦 integration-tests/devtools

✖ io.quarkus.devtools.commands.CreateProjectTest.createMultipleTimes line 254 - More details - Source on GitHub

java.util.concurrent.TimeoutException: createMultipleTimes() timed out after 3 seconds
	at org.junit.jupiter.engine.extension.TimeoutExceptionFactory.create(TimeoutExceptionFactory.java:29)
	at org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:58)

⚙️ Maven Tests - JDK 11 #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.BuildIT.testClassLoaderLinkageError line 102 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.maven.it.BuildIT.testClassLoaderLinkageError line 102 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

✖ io.quarkus.maven.it.BuildIT.testClassLoaderLinkageError line 102 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

✖ io.quarkus.maven.it.BuildIT.testClassLoaderLinkageError line 102 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 

expected: 0

@cescoffier cescoffier merged commit c0b9b32 into quarkusio:main Mar 1, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 1, 2023
@cescoffier cescoffier deleted the devui-container-image branch March 1, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
area/core area/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.0.0.Alpha5
Development

Successfully merging this pull request may close these issues.
3 participants
@cescoffier @gsmet @phillip-kruger