2.13.x: Upgrade RESTEasy to 4.7.9.Final #30984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/dependencies
|
@jmartisk pls add description with some context for the upgrade |
|
I have checked the commits from the above linked comparison and nothing catches my eye. Checked JIRAs for the release too - https://issues.redhat.com/issues/?jql=project%20%3D%20RESTEASY%20AND%20fixVersion%20%3D%204.7.8.Final%20ORDER%20BY%20issuetype%20DESC |
|
resteasy/resteasy@6f9a198 is of interest (unless Jan has other changes in mind) but mime4j is now managed also at the bom level. |
|
|
This comment has been minimized.
This comment has been minimized.
|
We seem to have similar failures like we did in #27809 |
|
@jmartisk Hmm... ...4.7.8.Final doesn't have a default exception mapper so that property won't really do anything. The default exception mapper was required for Jakarta REST 3.1 so it's only in the 6.2 branch. I'm not too sure what would be causing it. If I get some time, I'll test it locally. |
|
It looks like the |
|
@Karm could you have a look at this branch and why the AWT tests are failing? Thanks! |
|
/me looking... |
|
So, this is unrelated to AWT/graphics per se, it's about how I wrote the test suite to work with passing image files back and forth between Quarkus server and the test suite client. It is also unrelated to native, at least I didn't get to that yet. The undermentioned example is in Java mode: With a started Quarkus server: The same curl call: executed with Quarkus 2.13.7.Final produces an expected png image. When I run the server built of this branch i.e. jmartisk:2.13-resteasy-4.7.8, I get this instead of a png image as a response: accompanied by HTTP 400 Bad Request. This is the endpoint code: The whole trace is available with FINE log level: 🔴 jmartisk:2.13-resteasy-4.7.8🟢 2.13.7.Final |
|
Would you like me to dive deeper or do you guys have it covered? @jmartisk? |
|
@Karm We'd like to get this upgrade into Quarkus 2.13.8, so yes it would be really nice if you could help us find a way to fix it. Thanks a lot! |
|
I tried to upgrade to RESTEasy 4.7.9.Final just in case. |
Failing Jobs - Building 23d9a8b
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ ✖ ⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ ✖ ⚙️ JVM Tests - JDK 18 #- Failing: integration-tests/logging-gelf
📦 integration-tests/logging-gelf✖ |
gsmet
changed the title
|
Yeah! |
rsvoboda
approved these changes
May 15, 2023
There was a problem hiding this comment.
additional set of changes - resteasy/resteasy@4.7.8.Final...4.7.9.Final
|
This is probably what fixed our issues: resteasy/resteasy@322f341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to include the latest fixes in RESTEasy