Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban commons-io from quarkus-core-deployment #30723

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Ban commons-io from quarkus-core-deployment #30723

merged 1 commit into from
Jan 31, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 30, 2023

Follow-up of #30542

@gsmet gsmet requested a review from famod January 30, 2023 17:09
famod
famod approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we keep the additional entry core/deployment/banned-signatures.txt as a safety net?

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 31, 2023

Failing Jobs - Building 84c1b5a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
⌛ JVM Tests - JDK 17 Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@gsmet
Copy link
Member Author

gsmet commented Jan 31, 2023

Yeah, it's already there, I don't think it hurts.

@gsmet gsmet merged commit 50c10ac into quarkusio:main Jan 31, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 31, 2023
@ninelore ninelore mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famod famod famod approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
3.0.0.Alpha4
Development

Successfully merging this pull request may close these issues.
2 participants
@gsmet @famod