Distinct generated count method from interface in REST Data with Panache #30530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added any test cases here because native tests are always cumbersome (as they increment the overall build time) and this scenario is already covered by Quarkus QE. However, let me know and I will add a new integration test to cover this case. |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
geoand
approved these changes
Jan 23, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native compilation fails because it detects that the generated method "count" does not match the method "count" from the interface. To solve this issue and to follow the same logic in the other generated methods, I've added a contextual uriInfo parameter, so the native compilation can't detect this method is the same as in the interface.
Moreover, I'm unsure why this is only spotted when using the elytron-security-properties-file module.
Fix #30515