Properly read the value of testcontainers.reuse.enable #30140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned by @LaunchPairs in the analysis of quarkusio#30059, the use of TestcontainersConfiguration#getUserProperty results in using only environment variables as the source for reading the testcontainers.reuse.enable. We should instead also read the value of ~/.testcontainers.properties in order to ensure we write back the proper value when restoring Fixes: quarkusio#30059
geoand
commented
Jan 3, 2023
| @@ -88,7 +88,7 @@ public Result get() { | |||
| .loadClass("org.testcontainers.utility.TestcontainersConfiguration"); | |||
| Object configurationInstance = configurationClass.getMethod("getInstance").invoke(null); | |||
| String oldReusePropertyValue = (String) configurationClass | |||
| .getMethod("getUserProperty", String.class, String.class) | |||
| .getMethod("getEnvVarOrUserProperty", String.class, String.class) | |||
There was a problem hiding this comment.
There is also a case to be made for using getEnvVarOrProperty here, but let's be cautious and only broaden the scope a little instead of all the way
gastaldi
approved these changes
Jan 3, 2023
geoand
added
the
triage/waiting-for-ci
gsmet
approved these changes
Jan 3, 2023
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @LaunchPairs in the analysis of #30059, the use of
TestcontainersConfiguration#getUserPropertyresults in using only environment variables as the source for reading thetestcontainers.reuse.enable.We should instead also read the value of
~/.testcontainers.propertiesin order to ensure we write back the proper value when restoringFixes: #30059