-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinispan Configuration enchancements #30065
Merged
geoand
merged 1 commit into
quarkusio:main
from
karesti:deprecate-service-list-in-favor-of-url
Jan 5, 2023
Merged
Infinispan Configuration enchancements #30065
geoand
merged 1 commit into
quarkusio:main
from
karesti:deprecate-service-list-in-favor-of-url
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
karesti
commented
Dec 23, 2022
•
edited
Loading
edited
- Deprecate serverList for hosts (consistency with other extensions)
- Deprecate authUsername for username
- Deprecate authPassowrd for password
- Provide uri connection configuration
- Provide ssl provider, protocol and ciphers closes Support bouncyCastle libs + Infinispan + FIPS #25136
quarkus-bot
bot
added
area/documentation
area/infinispan
Infinispan
area/testing
labels
Dec 23, 2022
karesti
force-pushed
the
deprecate-service-list-in-favor-of-url
branch
from
December 23, 2022 18:03
0db7ba1
to
6feec51
Compare
This comment has been minimized.
This comment has been minimized.
karesti
force-pushed
the
deprecate-service-list-in-favor-of-url
branch
from
January 2, 2023 15:45
6feec51
to
48066a9
Compare
This comment has been minimized.
This comment has been minimized.
geoand
reviewed
Jan 3, 2023
...untime/src/main/java/io/quarkus/infinispan/client/runtime/InfinispanClientRuntimeConfig.java
Show resolved
Hide resolved
geoand
reviewed
Jan 3, 2023
...untime/src/main/java/io/quarkus/infinispan/client/runtime/InfinispanClientRuntimeConfig.java
Show resolved
Hide resolved
geoand
reviewed
Jan 3, 2023
...untime/src/main/java/io/quarkus/infinispan/client/runtime/InfinispanClientRuntimeConfig.java
Show resolved
Hide resolved
karesti
force-pushed
the
deprecate-service-list-in-favor-of-url
branch
from
January 3, 2023 09:34
48066a9
to
f02ae9d
Compare
This comment has been minimized.
This comment has been minimized.
karesti
force-pushed
the
deprecate-service-list-in-favor-of-url
branch
2 times, most recently
from
January 3, 2023 16:39
649550a
to
98c5b5d
Compare
This comment has been minimized.
This comment has been minimized.
@geoand I fixed the javadoc issue I missed |
* Deprecate serverList for hosts (consistency with other extensions) * Deprecate authUsername for username * Deprecate authPassowrd for password * Provide uri connection configuration * Provide ssl provider, protocol and ciphers
karesti
force-pushed
the
deprecate-service-list-in-favor-of-url
branch
from
January 4, 2023 09:13
98c5b5d
to
00dd66d
Compare
geoand
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
geoand
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Jan 4, 2023
is there anything else to be validated at this point @geoand ? |
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Ready to merge when CI successfully finishes
labels
Jan 5, 2023
This was referenced Jan 5, 2023
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.