Ensure that Kotlin subclass of QuarkusApplication works properly #30058
Conversation
There was a problem hiding this comment.
Looks like maybe another test might be needed if i'm reading this code correctly but otherwise seems fine. This test is in the gradle IT tree but it doesn't look like there's anything specifically tied to gradle here so there's nothing to be done for maven, yes?
| import io.quarkus.runtime.annotations.QuarkusMain | ||
|
|
||
| @QuarkusMain(name = "my-main") | ||
| class MyMainClass : QuarkusApplication { |
There was a problem hiding this comment.
This all looks fine to me, in general, but I'm curious why this wouldn't have the super class in the check above. or is that check intended for top level functions and this test just doesn't exercise that code path?
There was a problem hiding this comment.
Right. I could add another level of superclass in order to exercise the recursive lookup.
Exactly. The reason I added it to the gradle tests is because we didn't have any more Kotlin modules in the integration-tests |
Fixes: quarkusio#30190 Follows up on: quarkusio#30058 (which incorrectly checked for QuarkusApplication as a superclass)
Fixes: quarkusio#30190 Follows up on: quarkusio#30058 (which incorrectly checked for QuarkusApplication as a superclass)
Fixes: quarkusio#30190 Follows up on: quarkusio#30058 (which incorrectly checked for QuarkusApplication as a superclass) (cherry picked from commit d5fb7fc)
Fixes: quarkusio#30190 Follows up on: quarkusio#30058 (which incorrectly checked for QuarkusApplication as a superclass)
Fixes: #30054