Pass missing properties to Hibernate Reactive startup #29981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/hibernate-reactive
|
I can't remember right now what we do underneath, but there is a difference in setting |
|
Not sure about |
|
@DavideD I think it can't hurt to stay consistent, worst case it is simply ignored. |
|
I agree. I think we can merge this |
geoand
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29956
@DavideD I'm not sure if this is enough to actually fix the issue given they are properties that are supposed to be passed to the JDBC driver so I have no idea if you try to pass them to the reactive driver.
So feel free to close if it's useless.