Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel Upgrade to v.1.21.0 #29863

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Dec 14, 2022

We skipped 1.20.x because it was a bit unstable. No Big changes since 1.19.
Some aws libs needed for tests were moved to contrib. In the future we will rewrite those tests to get rid of the dependencies.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/tracing labels Dec 14, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 14, 2022

/cc @radcortez(opentelemetry)

Comment on lines +29 to +30
<opentelemetry-aws.contrib.version>1.20.1-alpha</opentelemetry-aws.contrib.version>
<opentelemetry-aws-xray.contrib.version>1.20.1</opentelemetry-aws-xray.contrib.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any indication of how these are going to be managed? The issue is ensuring they are compatible with our OTel version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They need to be moved out of core. Created this: #29879

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@gsmet
Copy link
Member

gsmet commented Dec 15, 2022

We usually don't backport minor version bumps. Is there a specific reason to do so in this case?

@brunobat
Copy link
Contributor Author

@gsmet we can live with it only in main. Thanks

@michalvavrik
Copy link
Member

@brunobat @radcortez As long as you are fine with changes, please merge PR so that I can rebase mine. Thanks

@radcortez radcortez merged commit ae59f72 into quarkusio:main Dec 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 19, 2022
@brunobat brunobat deleted the bump-otel-1.21.0 branch August 21, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/tracing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants