Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ':z' bind option when using MacOS and Podman #29850

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Drop ':z' bind option when using MacOS and Podman #29850

merged 1 commit into from
Dec 19, 2022

Conversation

ranjanashish
Copy link
Contributor

When running the following build command on MacOS with Podman

$ ./gradlew build -Dquarkus.package.type=native -Dquarkus.native.container-build=true

the following error is thrown

Error: preparing container c96068474ff1b0fcf87bcca369f795f4ba2ef842d56f1f0551914c74a7369e97 for attach: lsetxattr /Users/<trimmed-path>-1.0.0-SNAPSHOT-native-image-source-jar/lib: operation not supported

This PR fixes the above issue.

Related:

MacOS version: 13.1
Podman version: 4.3.1

@geoand geoand requested a review from zakkak December 14, 2022 09:05
gsmet
gsmet reviewed Dec 14, 2022
View reviewed changes
...ment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildLocalContainerRunner.java
@@ -116,8 +116,14 @@ protected List<String> getContainerRuntimeBuildArgs() {
volumeOutputPath = FileUtil.translateToVolumePath(volumeOutputPath);
}

String selinuxBindOption = ":z";
if (SystemUtils.IS_OS_MAC
&& ContainerRuntimeUtil.detectContainerRuntime() == ContainerRuntimeUtil.ContainerRuntime.PODMAN) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: will it work with Docker? I would expect it to fail on macOS in both cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will test it with MacOS and Docker, and report back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with Quarkus 2.14.3 on another MacOS with Docker and it worked without any issues. So, this looks to be affecting only Podman.

Another machine details:
MacOS version: 12.6
Docker version: 20.10.12

zakkak
zakkak reviewed Dec 14, 2022
View reviewed changes
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it but it looks OK to me.

To my understanding this is actually a podman issue though so it would be better if someone could confirm the latter with upstream podman first. Then we could have this patch in referencing the podman issue.

gsmet
gsmet approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 15, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 15, 2022

Failing Jobs - Building 2954a9f

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 17 MacOS M1
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/smallrye-graphql/deployment 
! Skipped: extensions/smallrye-graphql-client/deployment integration-tests/hibernate-orm-graphql-panache integration-tests/smallrye-graphql and 1 more

📦 extensions/smallrye-graphql/deployment

✖ io.quarkus.smallrye.graphql.deployment.RequestLeakDetectionTest.testWithConcurrentCalls line 63 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.smallrye.graphql.deployment.RequestLeakDetectionTest that uses java.util.List, java.util.Listint was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@ranjanashish
Copy link
Contributor Author

Please let me know if any other details are required from my end.

@zakkak zakkak added triage/flaky-test and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Dec 19, 2022
@zakkak zakkak merged commit 4f42868 into quarkusio:main Dec 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 19, 2022
@ranjanashish
Copy link
Contributor Author

Thank you @gsmet and @zakkak.

@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
@josephearl josephearl mentioned this pull request Dec 22, 2022
Open
@gsmet gsmet modified the milestones: 2.15.1.Final, 2.13.8.Final May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkak zakkak zakkak left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core triage/flaky-test
Projects
None yet
Milestone
2.13.8.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@ranjanashish @gsmet @zakkak