Look for test classes in the model loaded from the Gradle tooling #29808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
This comment has been minimized.
This comment has been minimized.
gsmet
reviewed
Dec 13, 2022
| @@ -46,6 +46,7 @@ public QuarkusPluginExtension(Project project) { | |||
| } | |||
|
|
|||
| public void beforeTest(Test task) { | |||
| project.getLogger().info("QuarkusPluginExtension.beforeTask " + task.getName()); | |||
There was a problem hiding this comment.
Hmmm, do we want to keep that info log? It looks like a debug message.
There was a problem hiding this comment.
The issue is that loading an app model this way is known to be slow. It could take 5 sec, for example, or even longer. I added it just for that reason and because it's only for launching from an IDE use-case.
There was a problem hiding this comment.
Well, in that case, it should be a message that an end user can understand such as Loading the application model... or something similar?
There was a problem hiding this comment.
Oh, sorry! I thought of a different info message I added in another place. Yes, this is a leftover, thanks for spotting it!
aloubyansky
force-pushed
the
gradle-test-from-ide
branch
from
b347cfb to
87eb67f
Compare
glefloch
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, when Quarkus tests are launched from an IDE for Gradle projects as "JUnit tests", test classes will be looked up in directories provided by the application model loaded with the Gradle tooling API.
This kind of class look up should be done for all cases, including Maven. I guess this could be the first step towards that refactoring.