Fix combination of @QuarkusMain and Kotlin native application #29755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanchooly
suggested changes
Dec 8, 2022
core/deployment/src/main/java/io/quarkus/deployment/steps/MainClassBuildStep.java
Outdated
Show resolved
Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/RegisterForReflectionBuildStep.java
Outdated
Show resolved
Hide resolved
...ation-tests/kotlin-serialization/src/main/kotlin/io/quarkus/it/kotser/GreetingApplication.kt
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
geoand
force-pushed
the
#29754
branch
2 times, most recently
from
382313b to
6e54c0c
Compare
evanchooly
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
This fix is better but it makes assumptions about the name the class matching the file name. It creates subtle holes (subtler than the original issue in some ways) that are likely to crop up later. I don't like this approach and am generally opposed but if users expect this kind of behavior when coming from Spring then I can plug my nose and move past it.
|
If this pattern where not proposed on the Kotlin page itself, I would not insist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29754