Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javadoc to UniAsserter #29634

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 2, 2022

Relates to: #29617

@geoand geoand requested a review from mkouba December 2, 2022 08:15
@quarkus-bot

This comment has been minimized.

@geoand geoand force-pushed the uniasserter-javadoc branch from 841d497 to 2367ff7 Compare December 2, 2022 08:33
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one minor comment. Otherwise looks good!

@geoand geoand force-pushed the uniasserter-javadoc branch from 2367ff7 to 38b2443 Compare December 2, 2022 08:55
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 2, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 2, 2022

Failing Jobs - Building 38b2443

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@geoand geoand merged commit cdac72c into quarkusio:main Dec 2, 2022
@geoand geoand deleted the uniasserter-javadoc branch December 2, 2022 09:34
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 2, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants