Avoid Gradle internal API CompositeProjectComponentArtifactMetadata #29622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
glefloch
approved these changes
Dec 1, 2022
|
@aloubyansky I have a lot of conflicts when backporting this one to 2.14. I'm wondering if we actually need to backport it. Could you check? |
|
@gsmet feel free to skip it then. We can revisit in case someone complains. |
gsmet
reviewed
Dec 5, 2022
| @@ -28,7 +28,6 @@ | |||
| import org.gradle.api.tasks.SourceSet; | |||
| import org.gradle.api.tasks.SourceSetContainer; | |||
| import org.gradle.api.tasks.compile.AbstractCompile; | |||
| import org.gradle.composite.internal.CompositeProjectComponentArtifactMetadata; | |||
| import org.gradle.internal.composite.IncludedBuildInternal; | |||
There was a problem hiding this comment.
@aloubyansky @glefloch isn't this class internal too? Wondering if there are alternatives.
There was a problem hiding this comment.
It is. It's not obvious how to avoid it for me. Ideally, we don't want to rely on internal API. @glefloch if you have some time to research this one, it'd be very much appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.