-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure bean params are @Typed
correctly for CDI lookup in case of subtyping
#29355
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
...yment/src/test/java/io/quarkus/resteasy/reactive/server/test/beanparam/BeanParamTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
package io.quarkus.resteasy.reactive.server.test.beanparam; | ||
|
||
import javax.ws.rs.BeanParam; | ||
import javax.ws.rs.CookieParam; | ||
import javax.ws.rs.FormParam; | ||
import javax.ws.rs.HeaderParam; | ||
import javax.ws.rs.POST; | ||
import javax.ws.rs.Path; | ||
import javax.ws.rs.PathParam; | ||
import javax.ws.rs.QueryParam; | ||
|
||
import org.jboss.shrinkwrap.api.ShrinkWrap; | ||
import org.jboss.shrinkwrap.api.spec.JavaArchive; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
||
import io.quarkus.test.QuarkusUnitTest; | ||
|
||
public class BeanParamTest { | ||
@RegisterExtension | ||
static final QuarkusUnitTest TEST = new QuarkusUnitTest() | ||
.setArchiveProducer(() -> { | ||
return ShrinkWrap.create(JavaArchive.class) | ||
.addClasses(MyBeanParamWithFieldsAndProperties.class, Top.class); | ||
}); | ||
|
||
@Test | ||
void shouldDeployWithoutIssues() { | ||
// we only need to check that it deploys | ||
} | ||
|
||
public static class Top { | ||
@PathParam("pathParam") | ||
private String pathParam = "pathParam"; | ||
|
||
public String getPathParam() { | ||
return pathParam; | ||
} | ||
|
||
public void setPathParam(String pathParam) { | ||
this.pathParam = pathParam; | ||
} | ||
} | ||
|
||
public static class MyBeanParamWithFieldsAndProperties extends Top { | ||
@HeaderParam("headerParam") | ||
private String headerParam = "headerParam"; | ||
@CookieParam("cookieParam") | ||
private String cookieParam = "cookieParam"; | ||
@FormParam("formParam") | ||
private String formParam = "formParam"; | ||
@QueryParam("queryParam") | ||
private String queryParam = "queryParam"; | ||
|
||
// FIXME: Matrix not supported | ||
|
||
public String getHeaderParam() { | ||
return headerParam; | ||
} | ||
|
||
public void setHeaderParam(String headerParam) { | ||
this.headerParam = headerParam; | ||
} | ||
|
||
public String getCookieParam() { | ||
return cookieParam; | ||
} | ||
|
||
public void setCookieParam(String cookieParam) { | ||
this.cookieParam = cookieParam; | ||
} | ||
|
||
public String getFormParam() { | ||
return formParam; | ||
} | ||
|
||
public void setFormParam(String formParam) { | ||
this.formParam = formParam; | ||
} | ||
|
||
public String getQueryParam() { | ||
return queryParam; | ||
} | ||
|
||
public void setQueryParam(String queryParam) { | ||
this.queryParam = queryParam; | ||
} | ||
} | ||
|
||
@Path("/") | ||
public static class Resource { | ||
@Path("/a/{restPathDefault}/{restPath_Overridden}/{pathParam}") | ||
@POST | ||
public String beanParamWithFields(@BeanParam MyBeanParamWithFieldsAndProperties p) { | ||
return null; | ||
} | ||
|
||
@Path("/b/{pathParam}") | ||
@POST | ||
public String beanParamWithFields(@BeanParam Top p) { | ||
return null; | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FroMage you could also check that the bean has all the expected types, see
ResourceBeanTypeTest
as an example.But I won't insist :)