Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo and improvement on the k8s guide #29213

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

loicmathieu
Copy link
Contributor

No description provided.

----
quarkus.kubernetes.ingress.expose=true
# To change the Ingress host. By default, it's empty.
quarkus.kubernetes.ingress.host=prod.svc.url
# To change the Ingress path of the generated Ingress rule. By default, it's "/".
quarkus.kubernetes.ports.http.path=/prod
quarkus.kubernetes.ingress.path=/prod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property does not exist, the right one is quarkus.kubernetes.ports.http.path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I messed up with rule configuration.

By the way, it's not very easy to understand why a Kubernetes port have a path ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very true... We should address this not-very user-friendly property sooner than later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can open an issue.
Should I close the PR or just remove this change ? Other change are cosmetic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it's fine to just remove this change and proceed with the rest.
And yes, feel free to open an issue to improve this configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line removed and issue create: #29279

@Sgitario Sgitario merged commit 4bd17f0 into quarkusio:main Nov 15, 2022
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Nov 15, 2022
@gsmet gsmet added triage/backport? triage/backport-2.13 and removed triage/invalid This doesn't seem right labels Nov 15, 2022
@gsmet gsmet added this to the 2.14.1.Final milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants