Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include interfaces as bean types of RR resources #29155

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Nov 9, 2022

Fixes #29128

This is a suggestion on how to fix the issue and works with the reproducer provided there. I've also run some basic tests in RR to see if it breaks anything and so far so good.

However, it isn't a silver bullet because there are other scenarios in which this won't suffice. For instance if these resources extend any user defined class and then injection is performed based on that class (which might be uncommon for RR resources anyway?).

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a fine solution for now. Let's just add some tests :)

@manovotn
Copy link
Contributor Author

manovotn commented Nov 9, 2022

I think this is a fine solution for now. Let's just add some tests :)

OFC, I wanted to see if there are any objections to it first.
I'll add something similar to the reproducer.

@mkouba
Copy link
Contributor

mkouba commented Nov 9, 2022

It looks good. Let's see if it breaks anything...

@quarkus-bot

This comment has been minimized.

@manovotn
Copy link
Contributor Author

manovotn commented Nov 9, 2022

@mkouba @geoand I've added a test very much like the one from provided reproducer.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 9, 2022

Failing Jobs - Building 47697e2

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 MacOS M1 #

- Failing: integration-tests/smallrye-opentracing 

📦 integration-tests/smallrye-opentracing

io.quarkus.it.opentracing.OpenTracingTestCase. line 35 - More details - Source on GitHub

java.lang.IllegalStateException: Could not find a valid Docker environment. Please see logs and check configuration
	at org.testcontainers.dockerclient.DockerClientProviderStrategy.lambda$getFirstValidStrategy$7(DockerClientProviderStrategy.java:256)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)

@geoand geoand merged commit 2e6008e into quarkusio:main Nov 10, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 10, 2022
@manovotn manovotn deleted the issue29128 branch November 10, 2022 07:54
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.1.Final Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocking Rest client does not work with 2.14.0.CR1
4 participants