-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include interfaces as bean types of RR resources #29155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a fine solution for now. Let's just add some tests :)
OFC, I wanted to see if there are any objections to it first. |
It looks good. Let's see if it breaks anything... |
This comment has been minimized.
This comment has been minimized.
…faces as its bean types
Failing Jobs - Building 47697e2
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 MacOS M1 #- Failing: integration-tests/smallrye-opentracing
📦 integration-tests/smallrye-opentracing✖
|
Fixes #29128
This is a suggestion on how to fix the issue and works with the reproducer provided there. I've also run some basic tests in RR to see if it breaks anything and so far so good.
However, it isn't a silver bullet because there are other scenarios in which this won't suffice. For instance if these resources extend any user defined class and then injection is performed based on that class (which might be uncommon for RR resources anyway?).