Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quarkus.qute.strict-rendering config property name in documentation #29148

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

zolv
Copy link

@zolv zolv commented Nov 9, 2022

A config property name to disable strict rendering of Qute is wrong.
Was: io.lquarkus.qute.strict-rendering - doesn't work,
Should be quarkus.qute.strict-rendering - works just fine.

@quarkus-bot quarkus-bot bot added the area/qute The template engine label Nov 9, 2022
@gsmet gsmet requested a review from mkouba November 9, 2022 12:46
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 9, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 9, 2022

Failing Jobs - Building a098396

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 MacOS M1 #

- Failing: integration-tests/mailer 

📦 integration-tests/mailer

io.quarkus.it.mailer.MailerTest.sendHtmlEmail - More details - Source on GitHub

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:625)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:696)

@gsmet gsmet merged commit d6e25aa into quarkusio:main Nov 9, 2022
@gsmet
Copy link
Member

gsmet commented Nov 9, 2022

Thanks for taking the time to create a PR!

@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 9, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 9, 2022
@zolv
Copy link
Author

zolv commented Nov 9, 2022

I've spent 30mins figuring out why Qute is still using a strict mode. I decided to just try as a dummy, to remove the suspicious io.... part and it worked.
I guess how many people lost their time on that 😄

@mkouba
Copy link
Contributor

mkouba commented Nov 9, 2022

You should always check the autogenerated configuration reference 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants