-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register all implementation of ExtensionAdapter in k8s client extension #29100
Conversation
cc @manusa |
Failing Jobs - Building 98f02aa
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
|
@iocanel can you take a look at this one? It would be nice to get it into the next 2.14 release. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing!
Thanks for the review |
Hi @geoand sorry for the late reply 😓 This one looks OK. However, maybe we want to do: serviceProviderProducer.produce(ServiceProviderBuildItem.allProvidersFromClassPath(ExtensionAdapter.class.getName())); for the Regarding this option If so, this will be very handy once we merge and release fabric8io/kubernetes-client#4511 |
@manusa thanks for the info. Feel free to send a PR updating the k8s client support |
👍 Will do. I'll probably tackle everything once we release Kubernetes Client 6.3.0 with the mentioned improvement (hopefully next week 🤞) |
👌 |
Actually, this can't be backported to 2.13 as |
Ah no, actually, it's there but in a different package. I will adjust the package in the backport. |
Fixes: #29096