Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure aroundInvoke interceptors get correct method parameters #29094

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Nov 7, 2022

Fixes #28783

@quarkus-bot

This comment was marked as outdated.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 7, 2022
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 8, 2022

Failing Jobs - Building 5c8b5a2

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 MacOS M1 #

- Failing: integration-tests/mailer integration-tests/smallrye-opentracing 

📦 integration-tests/mailer

io.quarkus.it.mailer.MailerTest.sendHtmlEmail - More details - Source on GitHub

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:625)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:696)

📦 integration-tests/smallrye-opentracing

io.quarkus.it.opentracing.OpenTracingTestCase. line 35 - More details - Source on GitHub

java.lang.IllegalStateException: Could not find a valid Docker environment. Please see logs and check configuration
	at org.testcontainers.dockerclient.DockerClientProviderStrategy.lambda$getFirstValidStrategy$7(DockerClientProviderStrategy.java:256)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)

@gsmet
Copy link
Member

gsmet commented Nov 8, 2022

@holly-cummins not sure what's going on here but the two tests failing on M1 are choking on Docker not being available (despite it being available to other tests).

@gsmet gsmet merged commit 854a3c0 into quarkusio:main Nov 8, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 8, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 8, 2022
@holly-cummins
Copy link
Contributor

Ohh, interesting. Thanks for spotting that, @gsmet. That sounds like the same symptom we saw in #28779. It was baffling over there (and we worked round it eventually by disabling the test), and it's confusing here, but if we're lucky the extra data point will shed some light.

I was hoping this might be the change that "introduced" the issue, but we had machine issues last week so we've lost too much information about runs to be able to identify a triggering change.

Looking at it in more detail, the logs are slightly different here compared to #28779. Here the logs report:

2022-11-07T23:14:22.3975950Z 2022-11-07 18:14:22,378 INFO  [org.tes.uti.ImageNameSubstitutor] (main) Image name substitution will be performed by: DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor')
2022-11-07T23:14:22.3976550Z 2022-11-07 18:14:22,388 INFO  [org.tes.doc.DockerClientProviderStrategy] (main) Loaded org.testcontainers.dockerclient.UnixSocketClientProviderStrategy from ~/.testcontainers.properties, will try it first
2022-11-07T23:14:22.3977240Z 2022-11-07 18:14:22,392 INFO  [org.tes.doc.DockerMachineClientProviderStrategy] (main) docker-machine executable was not found on PATH ([/Volumes/actions-files/githubactions/actions-runner/_work/_tool/Java_Temurin-Hotspot_jdk/17.0.5-8/aarch64/Contents/Home/bin, /opt/homebrew/bin/, /usr/local/bin, /usr/bin, /bin, /usr/sbin, /sbin])
2022-11-07T23:14:22.3977800Z 2022-11-07 18:14:22,393 ERROR [org.tes.doc.DockerClientProviderStrategy] (main) Could not find a valid Docker environment. Please check configuration. Attempted configurations were:
2022-11-07T23:14:22.3978530Z 	UnixSocketClientProviderStrategy: failed with exception InvalidConfigurationException (Could not find unix domain socket). Root cause NoSuchFileException (/var/run/docker.sock)As no valid configuration was found, execution cannot continue.
2022-11-07T23:14:22.3978900Z See https://www.testcontainers.org/on_failure.html for more details.

Over in the other issue the failure was

2022-10-21T04:12:53.1380870Z 2022-10-21 00:12:53,097 WARN  [io.qua.dep.IsDockerWorking] (build-23) No docker binary found or general error: java.lang.RuntimeException: Input/Output error while executing command.```

In this case the failure is coming from the testcontainers stack, and in the other one it was coming from our util code. I suspect the root cause is the same, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate validation fails on a constructor parameter validation
5 participants