-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure aroundInvoke interceptors get correct method parameters #29094
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building 5c8b5a2
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 MacOS M1 #- Failing: integration-tests/mailer integration-tests/smallrye-opentracing
📦 integration-tests/mailer✖
📦 integration-tests/smallrye-opentracing✖
|
@holly-cummins not sure what's going on here but the two tests failing on M1 are choking on Docker not being available (despite it being available to other tests). |
Ohh, interesting. Thanks for spotting that, @gsmet. That sounds like the same symptom we saw in #28779. It was baffling over there (and we worked round it eventually by disabling the test), and it's confusing here, but if we're lucky the extra data point will shed some light. I was hoping this might be the change that "introduced" the issue, but we had machine issues last week so we've lost too much information about runs to be able to identify a triggering change. Looking at it in more detail, the logs are slightly different here compared to #28779. Here the logs report:
Over in the other issue the failure was
In this case the failure is coming from the testcontainers stack, and in the other one it was coming from our util code. I suspect the root cause is the same, though. |
Fixes #28783