Fix logging with panache in interfaces #29090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging transformation used to add a `private static final` field to each transformed class. This is invalid in case the transformed class is in fact an interface, because the JVMS requires interface fields to always be `public static final`. With this commit, the logging transformation still adds `private` fields to regular classes, but when the transformed class is an interface, the generated field is `public`. This is not very nice, but working code trumps aesthetically pleasing code.
gsmet
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging transformation used to add a
private static finalfield to each transformed class. This is invalid in case the transformed class is in fact an interface, because the JVMS requires interface fields to always bepublic static final.With this commit, the logging transformation still adds
privatefields to regular classes, but when the transformed class is an interface, the generated field ispublic. This is not very nice, but working code trumps aesthetically pleasing code.Fixes #29072