Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement per persistence unit configuration for Hibernate Envers #28927

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Implement per persistence unit configuration for Hibernate Envers #28927

merged 1 commit into from
Oct 31, 2022

Conversation

tmihalac
Copy link
Contributor

Fixes #28133
Signed-off-by: Theodor Mihalache [email protected]

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Oct 30, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 30, 2022

/cc @Sanne, @gsmet, @yrodiere

@tmihalac tmihalac mentioned this pull request Oct 30, 2022
Closed
yrodiere
yrodiere requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few comments, see below. The nullcheck deserves a second look IMO.

...eployment/src/main/java/io/quarkus/hibernate/envers/deployment/HibernateEnversProcessor.java Outdated Show resolved Hide resolved
...s/deployment/src/test/java/io/quarkus/hibernate/orm/envers/EnversConfigurationPerPUTest.java Outdated Show resolved Hide resolved
...ernate-envers/runtime/src/main/java/io/quarkus/hibernate/envers/HibernateEnversRecorder.java Outdated Show resolved Hide resolved
@tmihalac tmihalac force-pushed the issue_28133 branch 2 times, most recently from fbf9493 to b9cb38d Compare October 31, 2022 07:50
@tmihalac tmihalac requested a review from yrodiere October 31, 2022 07:51
yrodiere
yrodiere approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, let's merge once CI passes unless there's an objection.

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 31, 2022
@Sanne
Copy link
Member

Sanne commented Oct 31, 2022

Awesome, thanks a lot!

@geoand geoand merged commit 529e29e into quarkusio:main Oct 31, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Oct 31, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Milestone
2.15.0.CR1
Development

Successfully merging this pull request may close these issues.

Implement per persistence unit configuration for Hibernate Envers
4 participants
@tmihalac @Sanne @yrodiere @geoand