Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserTransaction should fire CDI context lifecycle events #28725

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 20, 2022

@mkouba mkouba changed the title UserTransaction should fire context lifecycle events UserTransaction should fire CDI context lifecycle events Oct 20, 2022
@quarkus-bot quarkus-bot bot added the area/narayana Transactions / Narayana label Oct 20, 2022
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from CDI point of view!

@mkouba mkouba force-pushed the issue-28709 branch 2 times, most recently from 9b66eef to f5afe2b Compare October 21, 2022 07:41
@mkouba mkouba marked this pull request as ready for review October 21, 2022 07:41
@mkouba mkouba requested review from manovotn and mmusgrov and removed request for mmusgrov October 21, 2022 07:41
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only added one small comment.

@mkouba
Copy link
Contributor Author

mkouba commented Oct 21, 2022

@mmusgrov feel free to push the "merge' button if you're ok with this fix.

@geoand
Copy link
Contributor

geoand commented Oct 25, 2022

@mmusgrov can you take a look at this?

@mmusgrov
Copy link
Contributor

@geoand sorry for the delay, I've added a comment to the conversation between @mkouba and @manovotn

@geoand
Copy link
Contributor

geoand commented Oct 25, 2022

Thanks @mmusgrov

@mkouba
Copy link
Contributor Author

mkouba commented Oct 25, 2022

@mmusgrov comments resolved :-)

@quarkus-bot

This comment has been minimized.

Copy link
Contributor

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 26, 2022
@mkouba mkouba merged commit aff4580 into quarkusio:main Oct 26, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Oct 26, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 26, 2022
@wicksim
Copy link

wicksim commented Jan 5, 2023

@mkouba Is this included in any 2.15.X? Because I can not see it in the release notes.

@mkouba
Copy link
Contributor Author

mkouba commented Jan 5, 2023

@mkouba Is this included in any 2.15.X? Because I can not see it in the release notes.

Yes, it is. The release blog posts do not list all the bugfixes/features. You can find it in the full changelog of 2.15.0.CR1 though: https://github.com/quarkusio/quarkus/releases/tag/2.15.0.CR1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/narayana Transactions / Narayana kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuarkusTransaction does not fire @Initialized(TransactionScoped.class)
5 participants