Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13] Update to ubi 8.6 and the latest openjdk images #28362

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Oct 3, 2022

Update to ubi 8.6 and the latest openjdk images

PR for main: #27997
(can't be easily back-ported, includes move to multi-arch images)

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/kubernetes area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 3, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 4, 2022

Failing Jobs - Building 2b5ec2c

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: devtools/cli integration-tests/oidc-code-flow 

📦 devtools/cli

io.quarkus.cli.CliProjectJBangTest.testCreateAppDefaults line 64 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {

📦 integration-tests/oidc-code-flow

io.quarkus.it.keycloak.CodeFlowTest.testTokenAutoRefresh line 507 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 500 Internal Server Error for http://localhost:8081/tenant-autorefresh?state=32520853-7670-4862-a1b6-1e29ce050b31&session_state=c2489868-4b61-414a-b3fb-d5276984684c&code=13ce0926-9e2c-4c36-9b09-b8d45180239d.c2489868-4b61-414a-b3fb-d5276984684c.e21791cd-866c-482a-a508-813c8f2f6f02
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.loadDownloadedResponses(WebClient.java:2452)

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/oidc-token-propagation-reactive 

📦 integration-tests/oidc-token-propagation-reactive

io.quarkus.it.keycloak.OidcTokenReactivePropagationTest.testGetUserNameWithAccessTokenPropagation line 22 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/frontend/access-token-propagation
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:461)

io.quarkus.it.keycloak.OidcTokenReactivePropagationTest.testNoToken line 43 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <302> but was <401>.

@rsvoboda
Copy link
Member Author

rsvoboda commented Oct 4, 2022

Those OIDC failures do not seem related to the changes in this PR,

devtools/cli fails on JBang issue

2022-10-03T20:40:40.7086833Z [ERROR]   CliProjectJBangTest.testCreateAppDefaults:64 Expected OK return code. Result:
2022-10-03T20:40:40.7087167Z result: {
2022-10-03T20:40:40.7087349Z   exitCode: {1},
2022-10-03T20:40:40.7087584Z   system_err: {Downloading JBang...
2022-10-03T20:40:40.7087826Z Error downloading JBang
2022-10-03T20:40:40.7088012Z },

@rsvoboda rsvoboda changed the title Update to ubi 8.6 and the latest openjdk images [2.13] Update to ubi 8.6 and the latest openjdk images Oct 4, 2022
@gsmet
Copy link
Member

gsmet commented Oct 4, 2022

Yeah the failures are unrelated.

@gsmet gsmet requested a review from cescoffier October 4, 2022 09:12
@gsmet gsmet added this to the 2.13.1.Final milestone Oct 4, 2022
@cescoffier
Copy link
Member

We can merge it HOWEVER, the other images are not using ubi:8.5 - so you may end up with libraries differences and even linking errors.

The reason why they are not updated to 8.6 is a mess between CEKit and Github action, which fails to produce some images (the micro one). JDock does not have that issue (which explains why we have 8.6 in the multi-arch images).

I have spent some time looking into that issue, but it's unreproducible. In the worse case, if we want this, I will build and push the micro one from my laptop. But, it won't be bitwise identical.

@rsvoboda
Copy link
Member Author

rsvoboda commented Oct 4, 2022

Understand the concern a bit more now. S2I, graalvm and mandrel builder images are using 8.5. And the target would be running on 8.6 or 8.7 in the future.

Rolling the above images is not a cheap effort, @cescoffier would need to spend few days on it.

CC @tqvarnst ... we may end up stuck with 8.5 ubi for 2.13 branch for its lifecycle

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and try to fix the builder image issue.

@rsvoboda
Copy link
Member Author

rsvoboda commented Oct 5, 2022

@cescoffier will you also merge the PR or waiting for another feedback?

@gsmet gsmet removed this from the 2.13.1.Final milestone Oct 5, 2022
@cescoffier
Copy link
Member

@rsvoboda builders and based images have been updated. Good to go!

@cescoffier cescoffier merged commit 79cf3da into quarkusio:2.13 Oct 6, 2022
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Oct 20, 2022
pjgg pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Oct 20, 2022
…ockerFiles (#875)

* Sync of changes in Dockerfiles with upstream

quarkusio/quarkus#28362
quarkusio/quarkus@f335f7e
quarkusio/quarkus@79d7ed5
(cherry picked from commit d5e35f4)

* Enable back disabled tests

Additionally, remove tests for cases,
that are not going to be fixed and
create replacement tests, if possible

(cherry picked from commit b125c98)

* Fix flaky Kafka tests (#868)

(cherry picked from commit d904fbe)

Co-authored-by: Rostislav Svoboda <[email protected]>
Co-authored-by: Fedor Dudinskiy <[email protected]>
Co-authored-by: Michal Vavřík <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/kubernetes area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants