-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.13] Update to ubi 8.6 and the latest openjdk images #28362
Conversation
Failing Jobs - Building 2b5ec2c
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: devtools/cli integration-tests/oidc-code-flow
📦 devtools/cli✖
📦 integration-tests/oidc-code-flow✖
⚙️ JVM Tests - JDK 18 #- Failing: integration-tests/oidc-token-propagation-reactive
📦 integration-tests/oidc-token-propagation-reactive✖
✖
|
Those OIDC failures do not seem related to the changes in this PR, devtools/cli fails on JBang issue
|
Yeah the failures are unrelated. |
We can merge it HOWEVER, the other images are not using ubi:8.5 - so you may end up with libraries differences and even linking errors. The reason why they are not updated to 8.6 is a mess between CEKit and Github action, which fails to produce some images (the micro one). JDock does not have that issue (which explains why we have 8.6 in the multi-arch images). I have spent some time looking into that issue, but it's unreproducible. In the worse case, if we want this, I will build and push the micro one from my laptop. But, it won't be bitwise identical. |
Understand the concern a bit more now. S2I, graalvm and mandrel builder images are using 8.5. And the target would be running on 8.6 or 8.7 in the future. Rolling the above images is not a cheap effort, @cescoffier would need to spend few days on it. CC @tqvarnst ... we may end up stuck with 8.5 ubi for 2.13 branch for its lifecycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and try to fix the builder image issue.
@cescoffier will you also merge the PR or waiting for another feedback? |
@rsvoboda builders and based images have been updated. Good to go! |
quarkusio/quarkus#28362 quarkusio/quarkus@f335f7e quarkusio/quarkus@79d7ed5 (cherry picked from commit d5e35f4)
…ockerFiles (#875) * Sync of changes in Dockerfiles with upstream quarkusio/quarkus#28362 quarkusio/quarkus@f335f7e quarkusio/quarkus@79d7ed5 (cherry picked from commit d5e35f4) * Enable back disabled tests Additionally, remove tests for cases, that are not going to be fixed and create replacement tests, if possible (cherry picked from commit b125c98) * Fix flaky Kafka tests (#868) (cherry picked from commit d904fbe) Co-authored-by: Rostislav Svoboda <[email protected]> Co-authored-by: Fedor Dudinskiy <[email protected]> Co-authored-by: Michal Vavřík <[email protected]>
Update to ubi 8.6 and the latest openjdk images
PR for main: #27997
(can't be easily back-ported, includes move to multi-arch images)