Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly take produced media type into account when building validation error report #28343

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 3, 2022

Fixes: #28324

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 3, 2022

Failing Jobs - Building 7fa40d0

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

import javax.ws.rs.core.MediaType;
import javax.ws.rs.core.Response;
import javax.ws.rs.core.Response.Status;
import javax.ws.rs.ext.ExceptionMapper;
import javax.ws.rs.ext.Provider;

import org.jboss.resteasy.api.validation.Validation;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm. How did it even work? Shouldn't have it failed with a CNFE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two words: constant inlining :)

@gsmet gsmet merged commit 2bd4569 into quarkusio:main Oct 3, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 3, 2022
@geoand geoand deleted the #28324 branch October 3, 2022 11:35
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate validator responses with wrong Content-Type header when working in reactive mode
2 participants