-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kotlin.version 1.7.20 #28338
Update kotlin.version 1.7.20 #28338
Conversation
/cc @gsmet, @manovotn, @maxandersen, @radcortez, @Sanne |
bf6727b
to
423ec3c
Compare
It looks like the M1 Job fails during setup. Is this to be expected? Is there something I can do about it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to prepare the 1.7.20 branch for Jakarta before we merge this.
This comment has been minimized.
This comment has been minimized.
@gsmet : When you think you can provide the branch? If you want, I might be able to send you a PR. In general: Why does Quarkus need a separate branch of Kotlin? Could it make sense to try to get these changes into upstream Kotlin? |
423ec3c
to
71dd94d
Compare
Ah thanks, it slipped my mind. We need a Kotlin branch for the Jakarta transformation script: gsmet/kotlin@4c88596 . I need to be able to run a build without compiling anything and Kotlin was in the way. It's just for the transformation, the runtime version is still stock 1.7.20. I think it should be contributed back to Kotlin but I never found the time (the patch is simple but I have to idea if they expect tests or things like that). If you can do it, that would be awesome. |
I prepared the branch and squashed the commits. |
Replaces #28332. It seems dependabot missed a couple of occurences of the kotlin version.