Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin.version 1.7.20 #28338

Merged

Conversation

andreas-eberle
Copy link
Contributor

Replaces #28332. It seems dependabot missed a couple of occurences of the kotlin version.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/jakarta labels Oct 1, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 1, 2022

@andreas-eberle andreas-eberle force-pushed the feature/update-kotlin.version-1.7.20 branch from bf6727b to 423ec3c Compare October 1, 2022 12:09
@andreas-eberle
Copy link
Contributor Author

It looks like the M1 Job fails during setup. Is this to be expected? Is there something I can do about it?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to prepare the 1.7.20 branch for Jakarta before we merge this.

@quarkus-bot

This comment has been minimized.

@andreas-eberle
Copy link
Contributor Author

@gsmet : When you think you can provide the branch? If you want, I might be able to send you a PR.

In general: Why does Quarkus need a separate branch of Kotlin? Could it make sense to try to get these changes into upstream Kotlin?

@gsmet gsmet force-pushed the feature/update-kotlin.version-1.7.20 branch from 423ec3c to 71dd94d Compare October 4, 2022 13:38
@gsmet
Copy link
Member

gsmet commented Oct 4, 2022

Ah thanks, it slipped my mind.

We need a Kotlin branch for the Jakarta transformation script: gsmet/kotlin@4c88596 . I need to be able to run a build without compiling anything and Kotlin was in the way. It's just for the transformation, the runtime version is still stock 1.7.20.

I think it should be contributed back to Kotlin but I never found the time (the patch is simple but I have to idea if they expect tests or things like that). If you can do it, that would be awesome.

@gsmet
Copy link
Member

gsmet commented Oct 4, 2022

I prepared the branch and squashed the commits.

@gsmet gsmet merged commit 726645a into quarkusio:main Oct 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 4, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Oct 4, 2022
@andreas-eberle andreas-eberle deleted the feature/update-kotlin.version-1.7.20 branch May 13, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/jakarta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants