Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not to ignore the property quarkus.kubernetes.ports.<name>.protocol #28310

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Not to ignore the property quarkus.kubernetes.ports.<name>.protocol #28310

merged 1 commit into from
Oct 4, 2022

Conversation

Sgitario
Copy link
Contributor

Relates to #28297

@Sgitario Sgitario mentioned this pull request Sep 30, 2022
Closed
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 30, 2022

Failing Jobs - Building 7b9a896

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@Sgitario Sgitario requested a review from iocanel September 30, 2022 10:50
iocanel
iocanel approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sgitario Sgitario merged commit edbdf1a into quarkusio:main Oct 4, 2022
@Sgitario Sgitario deleted the fix_kubernetes_protocol branch October 4, 2022 09:19
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Oct 4, 2022
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.1.Final Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/kubernetes
Projects
None yet
Milestone
2.13.1.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@Sgitario @iocanel @geoand @gsmet