Fix NPE when the subprotocol of websocket is null #28268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
gsmet
changed the title
gsmet
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
I fixed a typo in subprotocal in the warn message and also made a few more changes, the most "important" one being avoiding a string concatenation for a debug message that will probably never be displayed.
All force pushed to your branch so let's wait for CI and merge.
gsmet
added
the
triage/waiting-for-ci
|
Ok thanks for the fix! |
|
And merged, thanks! |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue related to a NPE in
SmallRyeGraphQLOverWebSocketHandler.javawhen connecting with websocatThe fix is tested against the reproducer provided in the issue