-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distrust maven settings location from system properties #28141
Conversation
devtools/cli/src/test/java/io/quarkus/cli/RegistryClientBuilderTestBase.java
Outdated
Show resolved
Hide resolved
d7d3262
to
ff5d3b0
Compare
Thanks a lot @AdlerFleurant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't comment on the change itself, @aloubyansky already did, but I have a problem with you mixing this change with a bunch of cleanup that is totally unrelated.
If you're not able to do the split the PR easily yourself using your Git superpowers, I can do it myself.
devtools/cli/src/test/java/io/quarkus/cli/CliProjectJBangTest.java
Outdated
Show resolved
Hide resolved
ff5d3b0
to
a5ff366
Compare
This comment has been minimized.
This comment has been minimized.
a5ff366
to
0b45237
Compare
0b45237
to
cba2132
Compare
@gsmet . I think the latest changes should address your concern. I have reduced the scope of the change. I will submit another change for not using the deprecated API. |
@gsmet, how can I help this move forward? |
@gsmet, @aloubyansky, I think we can remove some of these labels as the scope of the change was reduced to just cli. |
Yeah sorry I was busy on other things. BTW, maybe I wasn't clear, but please push the other changes to another pull request. Cleanup is always welcome. |
I will rebase as somehow CI didn't start. |
Check if maven settings file exists when getting from system properties. Null check on mavenSettings. Fix nearby typos. Fixes quarkusio#28090 Signed-off-by: Adler Fleurant <[email protected]>
cba2132
to
2b0923f
Compare
Check if maven settings file exists when getting from system properties.
Null check on mavenSettings.
Fix nearby typos.
Fixes #28090