Avoid letting our transformation rules getting transformed #28140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Sep 22, 2022
gsmet
reviewed
Sep 22, 2022
| private static String forbiddenName() { | ||
| StringBuilder sb = new StringBuilder("java") | ||
| .append("x.") | ||
| .append("transaction"); |
There was a problem hiding this comment.
IIRC, I just fixed it by doing a "javax." + "transaction" where I faced the issue.
There was a problem hiding this comment.
But given you're transforming the bytecode and not the source, maybe it wouldn't work.
There was a problem hiding this comment.
yea, pretty sure that would have worked too. But didn't want to take chances - spent enough on this :)
gsmet
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28018
A cleaner solution would be to avoid transforming this extension, but I've not found a way to exclude a single one w/o making the whole script much more complicated.
This seems to work, but I only tried to run the jakarta transformation section of the script.