Use a timer when awaiting Quartz shutdown #28119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
reviewed
Sep 21, 2022
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java
Outdated
Show resolved
Hide resolved
geoand
force-pushed
the
quartz-defensive-shutdown
branch
from
456d802 to
cefafe8
Compare
|
PR updated |
geoand
force-pushed
the
quartz-defensive-shutdown
branch
2 times, most recently
from
d329d2a to
a4d38da
Compare
machi1990
reviewed
Sep 23, 2022
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
machi1990
reviewed
Sep 23, 2022
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
machi1990
reviewed
Sep 23, 2022
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
geoand
force-pushed
the
quartz-defensive-shutdown
branch
from
aadf369 to
5487f50
Compare
This comment has been minimized.
This comment has been minimized.
geoand
force-pushed
the
quartz-defensive-shutdown
branch
from
5487f50 to
16bc392
Compare
The Quartz scheduler shutdown seems like it can block indefinitely if there is an exception in a yet to be completed job. To guard against this, we ensure that we only wait a configurable amount of time for the scheduler to shut down. This is a breaking change because previously we waited indefinitely. Relates to quarkusio#28114 Co-authored-by: Manyanda Chitimbo <[email protected]>
geoand
force-pushed
the
quartz-defensive-shutdown
branch
from
16bc392 to
badebc8
Compare
geoand
added
the
triage/waiting-for-ci
mkouba
approved these changes
Sep 26, 2022
machi1990
approved these changes
Sep 26, 2022
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a timer when awaiting Quartz shutdown
The Quartz scheduler shutdown seems like it
can block indefinitely if there is an exception
in a yet to be completed job.
To guard against this, we ensure that we only
wait a configurable amount of time for the scheduler
to shut down.
This is a breaking change because previously we waited
indefinitely.
Relates to #28114