Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SmallRye Reactive Messaging to 3.19.1 #28117

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

ozangunalp
Copy link
Contributor

  • Update Kafka documentation
  • Update HR RM test with activate request context
  • Added HR ORM RM IT

Update Kafka documentation

Update HR RM test with activate request context

Added HR ORM RM IT
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation labels Sep 21, 2022
@geoand geoand requested a review from cescoffier September 21, 2022 09:21
@ozangunalp ozangunalp added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 21, 2022
@quarkus-bot

This comment has been minimized.

@ozangunalp
Copy link
Contributor Author

I think I previously ran all RM tests. I need to double check the failing test
io.quarkus.smallrye.reactivemessaging.amqp.AnonymousAmqpTest.test

@cescoffier
Copy link
Member

I think it's a flaky test. I got it failing a few times. We should disable it and investigate.

@ozangunalp ozangunalp removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 21, 2022
@ozangunalp
Copy link
Contributor Author

That test is still green for me. Maybe it is a windows issue?

@ozangunalp
Copy link
Contributor Author

@cescoffier Actually maybe we need to mark the outgoing channel durable, instead of the incoming one.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 22, 2022

Failing Jobs - Building f285603

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 17 MacOS M1
✔️ JVM Tests - JDK 18
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/oidc-code-flow 

📦 integration-tests/oidc-code-flow

io.quarkus.it.keycloak.CodeFlowTest.testTokenAutoRefresh line 518 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/tenant-autorefresh
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:461)

@cescoffier
Copy link
Member

Can you squash @ozangunalp ? It will make the backport easier.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the commits as is. They are semantic, it's better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants