-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more OIDC debug messages #28059
Add more OIDC debug messages #28059
Conversation
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/CodeAuthenticationMechanism.java
Outdated
Show resolved
Hide resolved
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/OidcIdentityProvider.java
Outdated
Show resolved
Hide resolved
b3195f3
to
bece40f
Compare
bc1200d
to
b944209
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@gastaldi Thanks for dealing with my sloppy typing in this PR :-) @gsmet, agree with you re the disruptive tests for sure; my thinking was, if it fails once every few days then I can keep it open. I've just thought about dealing it in private forks - it can definitely be done, but for tests experiencing the race conditions the chances are lower - example, in my fork I can do now and then with some update - but here the frequency is much higher, for example, we can have 20 PRs for 3 days, and now with the improved logging the chances of catching the problem will increase. That test tests an important but hard to test feature, a session extension via the token refresh, this is why I'd like to get it fixed as opposed to just disabling it... Either way, agree on the overall approach, we'll disable it next week if needed |
No description provided.