Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShift - Fix missing path to JAR that breaks app start #28038

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 18, 2022

fixes: #28037

Fixes app start in OpenShift as path to quarkus-run.jar is not set in conditions described by the linked issue.

@michalvavrik
Copy link
Member Author

cc @iocanel @Sgitario

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 18, 2022

Failing Jobs - Building e064c1c

Status Name Step Failures Logs Raw logs
Quickstarts Compilation - JDK 17 Compile Quickstarts Failures Logs Raw logs

Failures

⚙️ Quickstarts Compilation - JDK 17 #

- Failing: optaplanner-quickstart 

📦 optaplanner-quickstart

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project optaplanner-quickstart: Failed to build quarkus application

@michalvavrik
Copy link
Member Author

Quickstarts Compilation - JDK 17 goes down to Jandex issue that is not related (I've experienced same in other PR).

Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look ok to me. However, what about native? Doesn't require any fixing and work as it is now?

@michalvavrik
Copy link
Member Author

michalvavrik commented Sep 19, 2022

@Sgitario I think native changes are correctly done in #https://github.com/quarkusio/quarkus/issues/28037; I debugged reproducer now and way I think it works that entrypoint is set and called so there is no "java -jar stuff".

@Sgitario
Copy link
Contributor

@Sgitario I think native changes are correctly done in #https://github.com/quarkusio/quarkus/issues/28037; I debugged reproducer now and way I think it works that entrypoint is set and called so there is no "java -jar stuff".

ok ok, then we're good, thanks for the pull request!

@geoand geoand merged commit 9bc683f into quarkusio:main Sep 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 19, 2022
@michalvavrik michalvavrik deleted the feature/openshift-missing-jar-path branch September 19, 2022 12:16
@gsmet gsmet modified the milestones: 2.14 - main, 2.13.0.Final Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenShift - Fix missing JAR path
4 participants