Load main sourceSet only if present for project dependencies #27952
Conversation
quarkus-bot
bot
added
area/devtools
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
3 times, most recently
from
86c768e to
3de9cd2
Compare
AdlerFleurant
changed the title
This comment has been minimized.
This comment has been minimized.
|
@AdlerFleurant could you please run |
...ools/gradle/gradle-application-plugin/src/test/java/io/quarkus/gradle/QuarkusPluginTest.java
Outdated
Show resolved
Hide resolved
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
2 times, most recently
from
87c4f8c to
f3a3a8c
Compare
|
@aloubyansky star static imports seems to be ignored so I have changed it manually. |
This comment has been minimized.
This comment has been minimized.
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
from
f3a3a8c to
6d8314a
Compare
This comment has been minimized.
This comment has been minimized.
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
2 times, most recently
from
5cb8ff3 to
e8e28cf
Compare
This comment has been minimized.
This comment has been minimized.
|
@AdlerFleurant looks like the tests are failing in the CI. Could you please make sure they pass for you locally before push a new commit? Running tests paragraph may help locating the relevant tests to run. Thanks! |
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
from
e8e28cf to
0cc0f25
Compare
This comment has been minimized.
This comment has been minimized.
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
2 times, most recently
from
8993956 to
0883509
Compare
AdlerFleurant
changed the title
AdlerFleurant
changed the title
Missed this. I will make sure to run the test successfully before my next push. However, part of this seems to be from the CI. As it is trying to load some artifacts from the temporary test folder. |
This comment has been minimized.
This comment has been minimized.
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
from
0883509 to
9d67379
Compare
|
Do I need to rebase the branch before the merge? |
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
from
9d67379 to
596b21d
Compare
|
@Ladicek , @aloubyansky , the branch is rebased and the pull request that fixes optaplanner-quickstart was merged. This should run smoothly now. |
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
2 times, most recently
from
2d0144a to
a603f26
Compare
This comment has been minimized.
This comment has been minimized.
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
from
a603f26 to
7d94978
Compare
|
Not sure why this build failed on Windows. It seemed to be just a jitter. |
...ools/gradle/gradle-application-plugin/src/test/java/io/quarkus/gradle/QuarkusPluginTest.java
Outdated
Show resolved
Hide resolved
|
@gsmet @aloubyansky @glefloch, this is ready for review. |
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
from
7d94978 to
09a0297
Compare
|
@glefloch could you please review this one? Thanks! |
|
@AdlerFleurant could you rebase and force push? We don't want merge commits in PRs. |
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
from
db896d1 to
7973af2
Compare
Treating Extension Dependencies as optional Fixes quarkusio#27950 Signed-off-by: Adler Fleurant <[email protected]>
AdlerFleurant
force-pushed
the
no-fail-on-no-main-project-dependency
branch
from
7973af2 to
827f778
Compare
|
@gsmet I have updated into a single commit. |
|
Is there another action needed on my side to get this merged in @gsmet |
|
No, all good, thanks a lot @AdlerFleurant! |
Treating Extension Dependencies as optional
Fixes #27950